The following document contains the results of FindBugs Report
FindBugs Version is 1.3.8
Threshold is Low
Effort is Default
| Classes | Bugs | Errors | Missing Classes |
|---|---|---|---|
| 139 | 62 | 0 | 0 |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to ses in com.rc.celeritas.controller.CrudWMServlet.handle(WebContext) | STYLE | DLS_DEAD_LOCAL_STORE | 181 | Medium |
| com.rc.celeritas.controller.CrudWMServlet.characterEncoding is a mutable servlet field | MT_CORRECTNESS | MSF_MUTABLE_SERVLET_FIELD | 71 | Low |
| com.rc.celeritas.controller.CrudWMServlet.iluMap is a mutable servlet field | MT_CORRECTNESS | MSF_MUTABLE_SERVLET_FIELD | 402 | Low |
| com.rc.celeritas.controller.CrudWMServlet.srvCtx is a mutable servlet field | MT_CORRECTNESS | MSF_MUTABLE_SERVLET_FIELD | 69 | Low |
| Class com.rc.celeritas.controller.CrudWMServlet.characterEncoding extends Servlet class and uses instance variables | STYLE | MTIA_SUSPECT_SERVLET_INSTANCE_FIELD | 71 | Low |
| Class com.rc.celeritas.controller.CrudWMServlet.iluMap extends Servlet class and uses instance variables | STYLE | MTIA_SUSPECT_SERVLET_INSTANCE_FIELD | 139 | Low |
| Class com.rc.celeritas.controller.CrudWMServlet.srvCtx extends Servlet class and uses instance variables | STYLE | MTIA_SUSPECT_SERVLET_INSTANCE_FIELD | 69 | Low |
| Redundant nullcheck of t which is known to be null in com.rc.celeritas.controller.CrudWMServlet.handle(WebContext) | STYLE | RCN_REDUNDANT_NULLCHECK_OF_NULL_VALUE | 223 | Low |
| Class com.rc.celeritas.controller.CrudWMServlet defines non-transient non-serializable instance field srvCtx | BAD_PRACTICE | SE_BAD_FIELD | Not available | Low |
| com.rc.celeritas.controller.CrudWMServlet is Serializable; consider declaring a serialVersionUID | BAD_PRACTICE | SE_NO_SERIALVERSIONID | 49-447 | Low |
| Write to static field com.rc.celeritas.controller.CrudWMServlet.exportAuthMap from instance method com.rc.celeritas.controller.CrudWMServlet.start() | STYLE | ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD | 150 | Medium |
| Write to static field com.rc.celeritas.controller.CrudWMServlet.globalVarsMap from instance method com.rc.celeritas.controller.CrudWMServlet.start() | STYLE | ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD | 100 | Medium |
| Write to static field com.rc.celeritas.controller.CrudWMServlet.iluRefMap from instance method com.rc.celeritas.controller.CrudWMServlet.start() | STYLE | ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD | 135 | Medium |
| Write to static field com.rc.celeritas.controller.CrudWMServlet.luMap from instance method com.rc.celeritas.controller.CrudWMServlet.start() | STYLE | ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD | 122 | Medium |
| Write to static field com.rc.celeritas.controller.CrudWMServlet.sqlMap from instance method com.rc.celeritas.controller.CrudWMServlet.start() | STYLE | ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD | 89 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store of null to conn in com.rc.celeritas.db.DBHelper.closeConnection(Connection) | STYLE | DLS_DEAD_LOCAL_STORE_OF_NULL | 327 | Low |
| Incorrect lazy initialization of static field com.rc.celeritas.db.DBHelper.ds in com.rc.celeritas.db.DBHelper.init() | MT_CORRECTNESS | LI_LAZY_INIT_STATIC | 170-171 | Low |
| Method com.rc.celeritas.db.DBHelper.execute(String) may fail to clean up stream or resource of type java.sql.Statement | EXPERIMENTAL | OBL_UNSATISFIED_OBLIGATION | 364 | Medium |
| Method com.rc.celeritas.db.DBHelper.fetchRow(String) may fail to clean up stream or resource of type java.sql.ResultSet | EXPERIMENTAL | OBL_UNSATISFIED_OBLIGATION | 400 | Medium |
| Method com.rc.celeritas.db.DBHelper.fetchRow(String) may fail to clean up stream or resource of type java.sql.Statement | EXPERIMENTAL | OBL_UNSATISFIED_OBLIGATION | 399 | Medium |
| Method com.rc.celeritas.db.DBHelper.generateLU(String) may fail to clean up stream or resource of type java.sql.ResultSet | EXPERIMENTAL | OBL_UNSATISFIED_OBLIGATION | 101 | Medium |
| Method com.rc.celeritas.db.DBHelper.generateLU(String) may fail to clean up stream or resource of type java.sql.Statement | EXPERIMENTAL | OBL_UNSATISFIED_OBLIGATION | 100 | Medium |
| Method com.rc.celeritas.db.DBHelper.getColumns(String) may fail to clean up stream or resource of type java.sql.ResultSet | EXPERIMENTAL | OBL_UNSATISFIED_OBLIGATION | 269 | Medium |
| Method com.rc.celeritas.db.DBHelper.getColumns(String) may fail to clean up stream or resource of type java.sql.Statement | EXPERIMENTAL | OBL_UNSATISFIED_OBLIGATION | 268 | Medium |
| Method com.rc.celeritas.db.DBHelper.getColumnsFromSQL(String) may fail to clean up stream or resource of type java.sql.ResultSet | EXPERIMENTAL | OBL_UNSATISFIED_OBLIGATION | 300 | Medium |
| Method com.rc.celeritas.db.DBHelper.getColumnsFromSQL(String) may fail to clean up stream or resource of type java.sql.Statement | EXPERIMENTAL | OBL_UNSATISFIED_OBLIGATION | 298 | Medium |
| Method com.rc.celeritas.db.DBHelper.getQueryResults(String) may fail to clean up stream or resource of type java.sql.Statement | EXPERIMENTAL | OBL_UNSATISFIED_OBLIGATION | 147 | Medium |
| Method com.rc.celeritas.db.DBHelper.getRowMap(String) may fail to clean up stream or resource of type java.sql.ResultSet | EXPERIMENTAL | OBL_UNSATISFIED_OBLIGATION | 61 | Medium |
| Method com.rc.celeritas.db.DBHelper.getRowMap(String) may fail to clean up stream or resource of type java.sql.Statement | EXPERIMENTAL | OBL_UNSATISFIED_OBLIGATION | 60 | Medium |
| com.rc.celeritas.db.DBHelper.execute(String) may fail to close Statement | BAD_PRACTICE | ODR_OPEN_DATABASE_RESOURCE | 364 | Medium |
| com.rc.celeritas.db.DBHelper.fetchRow(String) may fail to close Statement | BAD_PRACTICE | ODR_OPEN_DATABASE_RESOURCE | 399 | Medium |
| com.rc.celeritas.db.DBHelper.generateLU(String) may fail to close Statement | BAD_PRACTICE | ODR_OPEN_DATABASE_RESOURCE | 100 | Medium |
| com.rc.celeritas.db.DBHelper.getColumns(String) may fail to close Statement | BAD_PRACTICE | ODR_OPEN_DATABASE_RESOURCE | 268 | Medium |
| com.rc.celeritas.db.DBHelper.getColumnsFromSQL(String) may fail to close Statement | BAD_PRACTICE | ODR_OPEN_DATABASE_RESOURCE | 298 | Medium |
| com.rc.celeritas.db.DBHelper.getQueryResults(String) may fail to close Statement | BAD_PRACTICE | ODR_OPEN_DATABASE_RESOURCE | 147 | Medium |
| com.rc.celeritas.db.DBHelper.getRowMap(String) may fail to close Statement | BAD_PRACTICE | ODR_OPEN_DATABASE_RESOURCE | 60 | Medium |
| Exception is caught when Exception is not thrown in com.rc.celeritas.db.DBHelper.getQueryResults(String) | STYLE | REC_CATCH_EXCEPTION | 151 | Low |
| Method com.rc.celeritas.db.DBHelper.execute(String) passes a nonconstant String to an execute method on an SQL statement | SECURITY | SQL_NONCONSTANT_STRING_PASSED_TO_EXECUTE | 365 | Low |
| Method com.rc.celeritas.db.DBHelper.fetchRow(String) passes a nonconstant String to an execute method on an SQL statement | SECURITY | SQL_NONCONSTANT_STRING_PASSED_TO_EXECUTE | 400 | Low |
| Method com.rc.celeritas.db.DBHelper.generateLU(String) passes a nonconstant String to an execute method on an SQL statement | SECURITY | SQL_NONCONSTANT_STRING_PASSED_TO_EXECUTE | 101 | Low |
| Method com.rc.celeritas.db.DBHelper.getColumns(String) passes a nonconstant String to an execute method on an SQL statement | SECURITY | SQL_NONCONSTANT_STRING_PASSED_TO_EXECUTE | 269 | Low |
| Method com.rc.celeritas.db.DBHelper.getColumnsFromSQL(String) passes a nonconstant String to an execute method on an SQL statement | SECURITY | SQL_NONCONSTANT_STRING_PASSED_TO_EXECUTE | 300 | Low |
| Method com.rc.celeritas.db.DBHelper.getQueryResults(String) passes a nonconstant String to an execute method on an SQL statement | SECURITY | SQL_NONCONSTANT_STRING_PASSED_TO_EXECUTE | 148 | Low |
| Method com.rc.celeritas.db.DBHelper.getRowMap(String) passes a nonconstant String to an execute method on an SQL statement | SECURITY | SQL_NONCONSTANT_STRING_PASSED_TO_EXECUTE | 61 | Low |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Method com.rc.celeritas.db.GenericDAO.getSingleColumnList(Connection, String) may fail to clean up stream or resource of type java.sql.ResultSet | EXPERIMENTAL | OBL_UNSATISFIED_OBLIGATION | 34 | Medium |
| Method com.rc.celeritas.db.GenericDAO.getSingleColumnList(Connection, String) may fail to clean up stream or resource of type java.sql.Statement | EXPERIMENTAL | OBL_UNSATISFIED_OBLIGATION | 33 | Medium |
| Method com.rc.celeritas.db.GenericDAO.getSingleColumnList(Connection, String) passes a nonconstant String to an execute method on an SQL statement | SECURITY | SQL_NONCONSTANT_STRING_PASSED_TO_EXECUTE | 34 | Low |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Class com.rc.celeritas.exception.CeleritasException is not derived from an Exception, even though it is named as such | BAD_PRACTICE | NM_CLASS_NOT_EXCEPTION | 16-45 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Class com.rc.celeritas.exception.ImpleoAlreadyExistException is not derived from an Exception, even though it is named as such | BAD_PRACTICE | NM_CLASS_NOT_EXCEPTION | 18-35 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Class com.rc.celeritas.exception.ImpleoMapEmptyException is not derived from an Exception, even though it is named as such | BAD_PRACTICE | NM_CLASS_NOT_EXCEPTION | 18-35 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Class com.rc.celeritas.exception.LessColumnInLookupSQLException is not derived from an Exception, even though it is named as such | BAD_PRACTICE | NM_CLASS_NOT_EXCEPTION | 18-35 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to message in com.rc.celeritas.impleo.DeleteImpleo.implied(WebContext) | STYLE | DLS_DEAD_LOCAL_STORE | 54 | Medium |
| com.rc.celeritas.impleo.DeleteImpleo.implied(WebContext) forgets to throw new Exception(String) | CORRECTNESS | RV_EXCEPTION_NOT_THROWN | 36 | High |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| com.rc.celeritas.impleo.DetailImpleo.implied(WebContext) forgets to throw new Exception(String) | CORRECTNESS | RV_EXCEPTION_NOT_THROWN | 36 | High |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| com.rc.celeritas.impleo.ExportImpleo.implied(WebContext) forgets to throw new Exception(String) | CORRECTNESS | RV_EXCEPTION_NOT_THROWN | 38 | High |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to message in com.rc.celeritas.impleo.InsertImpleo.implied(WebContext) | STYLE | DLS_DEAD_LOCAL_STORE | 60 | Medium |
| com.rc.celeritas.impleo.InsertImpleo.implied(WebContext) forgets to throw new Exception(String) | CORRECTNESS | RV_EXCEPTION_NOT_THROWN | 39 | High |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to message in com.rc.celeritas.impleo.SearchImpleo.implied(WebContext) | STYLE | DLS_DEAD_LOCAL_STORE | 60 | Medium |
| com.rc.celeritas.impleo.SearchImpleo.implied(WebContext) forgets to throw new Exception(String) | CORRECTNESS | RV_EXCEPTION_NOT_THROWN | 39 | High |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to message in com.rc.celeritas.impleo.UpdateImpleo.implied(WebContext) | STYLE | DLS_DEAD_LOCAL_STORE | 53 | Medium |
| com.rc.celeritas.impleo.UpdateImpleo.implied(WebContext) forgets to throw new Exception(String) | CORRECTNESS | RV_EXCEPTION_NOT_THROWN | 38 | High |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Method com.rc.celeritas.query.QueryHelper.createInsertSQL(String, ArrayList, Hashtable) uses the same code for two branches | STYLE | DB_DUPLICATE_BRANCHES | 117 | Medium |
